Renaming the node role search to warm #17573
Conversation
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
vinaykpud
changed the title
|
This is a straight rename correct? It does not resolve #17422 ? |
|
❌ Gradle check result for 835fd60: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
vinaykpud
force-pushed
the
rw/rename-role
branch
from
835fd60 to
a106fe2
Compare
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Yes, Do you want me to add a new issue for this? |
|
❌ Gradle check result for b0d026a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17573 +/- ##
============================================
- Coverage 72.43% 72.41% -0.02%
- Complexity 65721 65728 +7
============================================
Files 5311 5311
Lines 304941 304937 -4
Branches 44228 44226 -2
============================================
- Hits 220890 220829 -61
- Misses 65952 66040 +88
+ Partials 18099 18068 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vinaykpud
requested review from
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal and
linuxpi
as code owners
vinaykpud
requested review from
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
Let's make sure this aligns with what @gbbafna mentioned here before merging. We'd generally want to do a deprecation cycle before just replacing a term like this. However, it does appear that |
|
@vinaykpud : Can we verify if we upgrade the cluster from 2.x to 3.0 with this change, searchable snapshots continue to work ? There might be few nuances here like changing the cluster-manager first . Want to make sure that rolling restarts works with this change |
In this PR we are renaming the existing Node "Search Role" to "Warm Role"
Description
This is done based on the decision taken as part of the discussion in this thread: #17422 (comment)
Related Issues
Related to #15306
Related to #17422
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.